Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add py3.11+3.12 and pypy3.9+3.10 to CI, conditionally require exceptiongroup #183

Merged
merged 3 commits into from
Sep 26, 2023

Conversation

jakkdl
Copy link
Member

@jakkdl jakkdl commented Sep 26, 2023

I wrote this ... and then I saw the discussion in #180
So this is kind of a duplicate of that, except I also updated CI to test it, and general compatibility with 3.11/3.12, as well as pypy3.9 and pypy3.10.

I don't think there's any reason not to update so as not to require exceptiongroup on py3.11+, and it mirrors python-trio/trio.

pypy3.9 and pypy3.10 are the currently supported versions of python

As mentioned in the comment in ci.yml, running pylint on 3.12 crashes, see pylint-dev/pylint#8782

@jakkdl
Copy link
Member Author

jakkdl commented Sep 26, 2023

I had to bump cryptography in requirements-dev.txt to get pypy3.10 to work, but one should probably do a full bump of the requirements. I can do it in this PR if requested, but that's probably better done in a dedicated PR.

@jakkdl jakkdl requested a review from belm0 September 26, 2023 09:28
Copy link
Member

@Zac-HD Zac-HD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and I think it makes sense to match the behavior of Trio - this is the only lib I'm using which still requires exceptiongroup on Python 3.11.

@belm0 do you want to merge + release?

@@ -33,14 +33,15 @@
'Programming Language :: Python :: 3.9',
'Programming Language :: Python :: 3.10',
'Programming Language :: Python :: 3.11',
'Programming Language :: Python :: 3.12',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

usually I wouldn't declare an unreleased version, but I see trio does it

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah. FWIW CPython is up to rc3, and 3.12.0 final is due Monday, so we're not far in advance here.

@belm0 belm0 merged commit 929bf75 into python-trio:master Sep 26, 2023
9 checks passed
@jakkdl jakkdl deleted the ci_version_update branch May 30, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants