Drop Python 3.5 (third take) #1481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1481 +/- ##
==========================================
+ Coverage 92.82% 99.70% +6.88%
==========================================
Files 106 106
Lines 13292 13216 -76
Branches 1004 995 -9
==========================================
+ Hits 12338 13177 +839
+ Misses 903 24 -879
+ Partials 51 15 -36
|
Since we no longer support Python 3.5.
Since we no longer support Python 3.5.
KeyboardInterrupt protection is still enabled for async_generator, since users could still do this with Python 3.6. We can always deprecate this later.
pquentin
force-pushed
the
wgwz-drop-python3.5
branch
from
aa100e2
to
0097e3d
Compare
auvipy
approved these changes
Apr 29, 2020
|
Unfortunately the coverage isn't really useful, but the important thing to notice is that we were missing 24 lines before and that it's still the case now. Also, @njsmith will need to stop requiring the Python 3.5 checks. |
auvipy
approved these changes
Apr 29, 2020
njsmith
reviewed
Apr 30, 2020
| @@ -21,6 +21,7 @@ jobs: | |||
| env: | |||
| - "JOB_NAME='Ubuntu 19.10, full VM'" | |||
| - "VM_IMAGE=https://cloud-images.ubuntu.com/eoan/current/eoan-server-cloudimg-amd64.img" | |||
| - python: 3.6.1 # earliest 3.6 version available on Travis | |||
There was a problem hiding this comment.
Is there a specific motivation for this?
There was a problem hiding this comment.
Not really, I think I just mirrored the fact that we were supporting early versions of Python 3.5. In fact it looks like test_ki_wakes_us_up could be simplified if we decide to only support 3.6.2+.
Now that we're dropping 3.5 support, we can just write the code directly in the source file.
|
I can't approve my own pull request, but your additions look good to me, thanks! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1390, closes #75
I went to great lengths to make this easy to review commit by commit, by reorganizing the previous pull request.
There's one major change compared to #1390: even if it's not needed in Python 3.6, I decided to keep support for
async_generatorin user code. I also added a test for native async generators.