Correctly preserve exception __context__ in MultiError.catch #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Python's implicit exception chaining logic insists on corrupting __context__ when we re-raise an unpacked exception in MultiError.catch. This commit introduces a counter-measure.
Codecov Report
@@ Coverage Diff @@
## master #165 +/- ##
=========================================
- Coverage 98.43% 98.4% -0.03%
=========================================
Files 51 51
Lines 5939 5960 +21
Branches 468 470 +2
=========================================
+ Hits 5846 5865 +19
- Misses 79 80 +1
- Partials 14 15 +1
Continue to review full report at Codecov.
|
|
That's weird, appveyor seems to have just... not noticed this PR at all. It hasn't even attempted to build it. Maybe closing and opening again will make it notice? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python's implicit exception chaining logic insists on corrupting
context when we re-raise an unpacked exception in
MultiError.catch. This commit introduces a counter-measure.