-
-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try out coverage instead of pytest-cov #2665
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2665 +/- ##
==========================================
+ Coverage 98.11% 98.84% +0.72%
==========================================
Files 118 114 -4
Lines 16539 16514 -25
Branches 3003 3003
==========================================
+ Hits 16227 16323 +96
+ Misses 254 134 -120
+ Partials 58 57 -1
|
#2664 has the fix for the Ubuntu 3.11 failure. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, the code in testing/
is showing up as covered as expected!
Seems like we've lost coverage of test_multierror_scripts
since they're run with subprocess.run
. But looks like there's documentation on how to fix that: https://coverage.readthedocs.io/en/7.2.7/subprocess.html
Is the drop in trio/_core/_multierror.py also because of that?
The drop in trio/_tests/test_exports.py seems to be the test timeout on 3.12
so that's not an issue.
Wait a second, |
of course the thing that literally reads the file is not going to work. why did i miss that... |
welp no clue why the coverage for a few more files isn't working. i give up for now. |
I suppose we can just exclude |
Add leading wildcard to the omit path, in case that makes a difference
Huh, there's four codecov checks? :o Anyway, it looks good now - merging~~ |
... weird. Eh, we can fix that eventually! |
Ok, the four codecov thing was just cause this was an old PR: #2674 only has 2 checks! (as it should be) |
Not sure this will work. Fixes #2645