timeout functions now raise ValueError on NaN inputs #2667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2667 +/- ##
=======================================
Coverage 98.11% 98.11%
=======================================
Files 118 118
Lines 16534 16539 +5
Branches 3001 3003 +2
=======================================
+ Hits 16222 16227 +5
Misses 254 254
Partials 58 58
|
A5rocks
approved these changes
Jun 23, 2023
Comment on lines
+134
to
+136
| Args: | ||
| seconds (float): The timeout. | ||
|
|
There was a problem hiding this comment.
Just a comment that I really don't like how this is so easy to forget :S
There was a problem hiding this comment.
This sounds like something that can be auto-generated / have the signature displayed in another manner in the doc, once the public interface is fully typed.
A5rocks
requested changes
Jun 23, 2023
Hah! I've been working so much solely on internal stuff I completely forgot this was a thing, good catch! Feel free to merge if it looks good otherwise 🚀 |
A5rocks
approved these changes
Jun 24, 2023
newsfragments/2493.breaking.rst
Outdated
| @@ -0,0 +1 @@ | |||
| Timeout functions now raise `ValueError` if passed `nan`. This includes `trio.sleep`, `trio.sleep_until`, `trio.move_on_at`, `trio.move_on_after`, `trio.fail_at` and `trio.fail_after`. | |||
There was a problem hiding this comment.
I'd rather "NaN" over "nan"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2493
Consolidated all
ValueErrortests into a single test.