Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to
uv pip compile
#2958Switch to
uv pip compile
#2958Changes from 8 commits
f71fe81
6738ce4
76d8326
9f597e0
a20b4ce
6c8d62b
876d6a5
69b5868
7f211e5
a0a8b5a
4225702
6747417
383729f
72e3fbd
e5277f0
d75ef85
283e27b
148a995
1b95b71
7759de8
199160e
bb73318
42eceae
4f1438d
1748ca9
d1939e4
db7a7fe
2c15691
3a3778c
7255bd8
1b51930
d51aae3
572891a
dd5aa1a
96446a5
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change too seems wrong
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's intended, as we specify
--python-version=3.8
. If we generate separatetest-requirements-pyXX.txt
files for each python version we test we'll only getexceptiongroup
in the ones that are <3.11There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So I think that means we should have a
requirements
directory wherein we generate txt files for all versions we test.