Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump dependencies from commit d4268e #3068

Merged
merged 2 commits into from
Aug 21, 2024
Merged

Conversation

github-actions[bot]
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Aug 21, 2024
@github-actions github-actions bot enabled auto-merge (squash) August 21, 2024 01:56
@A5rocks
Copy link
Contributor

A5rocks commented Aug 21, 2024

Updating for uv 0.3 (mainly just checking theres no regressions in the output)

@A5rocks A5rocks closed this Aug 21, 2024
auto-merge was automatically disabled August 21, 2024 01:57

Pull request was closed

@A5rocks A5rocks reopened this Aug 21, 2024
@A5rocks A5rocks enabled auto-merge (squash) August 21, 2024 01:57
@A5rocks
Copy link
Contributor

A5rocks commented Aug 21, 2024

Only regression is in terms of simplification:

-colorama==0.4.6 ; sys_platform == 'win32' or (implementation_name == 'cpython' and platform_system == 'Windows')
+colorama==0.4.6 ; (implementation_name != 'cpython' and sys_platform == 'win32') or (platform_system != 'Windows' and sys_platform == 'win32') or (implementation_name == 'cpython' and platform_system == 'Windows')

Copy link

codecov bot commented Aug 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.63%. Comparing base (d4268e7) to head (4d18556).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #3068    +/-   ##
========================================
  Coverage   99.63%   99.63%            
========================================
  Files         121      121            
  Lines       17839    18047   +208     
  Branches     3206     3313   +107     
========================================
+ Hits        17774    17982   +208     
  Misses         46       46            
  Partials       19       19            

see 1 file with indirect coverage changes

@A5rocks
Copy link
Contributor

A5rocks commented Aug 21, 2024

Honestly, the regression is no big deal. I've reported it and if it gets fixed then nice. Also we should have these automatically apply changes from uv (just like with black currently).

@A5rocks A5rocks merged commit fbb9d50 into main Aug 21, 2024
66 checks passed
@A5rocks A5rocks deleted the autodeps/bump_from_d4268e branch August 21, 2024 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file skip newsfragment Newsfragment is not required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants