-
-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-3108: Avoid materializing f_locals for KI protection #3110
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3110 +/- ##
==========================================
+ Coverage 99.58% 99.62% +0.03%
==========================================
Files 121 122 +1
Lines 18166 18340 +174
Branches 3268 3281 +13
==========================================
+ Hits 18091 18271 +180
+ Misses 52 47 -5
+ Partials 23 22 -1
|
… code objects instead
e04b3d8
to
5d51c56
Compare
…ed to fix the use of Any
d44f023
to
ec30d7b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Plenty of nitpicks or me being confused; please don't assume I know what I'm doing with these comments. If the question doesn't make sense, it's cause I don't understand and not some weird encoded question.
Co-authored-by: EXPLOSION <git@helvetica.moe>
Co-Authored-By: oremanj <oremanj@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A bunch of really minor comments. This could merge as is without any changes IMO.
Nevermind, I was thinking about whether a deprecation is possible but it isn't because the problem is functions having ki protection only sometimes. |
pre-commit.ci autofix |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to be explicit, since all my comments were fixed and all my questions answered.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I can tell, this looks pretty great
Fixes #3108
Fixes #2670
In this pull request, we avoid materializing
f_locals
by using weak references to code objects instead.