Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Task.custom_sleep_data #616

Merged
merged 3 commits into from
Aug 21, 2018
Merged

Conversation

njsmith
Copy link
Member

@njsmith njsmith commented Aug 21, 2018

As discussed in #586

This replaces the gross hack where we mutated Task._abort_func
@codecov
Copy link

codecov bot commented Aug 21, 2018

Codecov Report

Merging #616 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #616      +/-   ##
==========================================
+ Coverage   99.31%   99.31%   +<.01%     
==========================================
  Files          91       91              
  Lines       10800    10808       +8     
  Branches      751      751              
==========================================
+ Hits        10726    10734       +8     
  Misses         56       56              
  Partials       18       18
Impacted Files Coverage Δ
trio/_core/_traps.py 100% <ø> (ø) ⬆️
trio/_core/tests/test_run.py 100% <100%> (ø) ⬆️
trio/_core/_run.py 100% <100%> (ø) ⬆️
trio/_core/_parking_lot.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1b56c6...c06c29e. Read the comment docs.

@njsmith
Copy link
Member Author

njsmith commented Aug 21, 2018

I think this is good to go, and I'll rebase #586 on top after it's merged.

Copy link
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I'm not familiar enough with those low level parts to hit merge right now. Let's wait a bit to see if someone else wants to review this.

@oremanj oremanj merged commit 5222984 into python-trio:master Aug 21, 2018
@oremanj
Copy link
Member

oremanj commented Aug 21, 2018

Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants