Bedevere as GH Actions #568
Conversation
Instead of getting information from webhook payload, get them from the Actions environment. Create fixtures for GitHub Actions environment vars. Adjust tests for __main__.py. Remove "ping" handler, not needed in Actions.
Codecov Report
@@ Coverage Diff @@
## main #568 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 18 19 +1
Lines 2083 2090 +7
Branches 234 241 +7
=========================================
+ Hits 2083 2090 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
For history: this PR resolves gh-344. |
Pass the GITHUB_TOKEN secret Check if GITHUB_EVENT_PATH env var exists.
|
I'm testing this on Mariatta/cpython#74 |
|
Sorry, I accidentally pushed a test to this branch. It didn't help so I've undone it. |
|
|
||
| from . import backport, gh_issue, close_pr, filepaths, news, stage | ||
|
|
||
| import sentry_sdk | ||
| # import sentry_sdk |
There was a problem hiding this comment.
Can we still use sentry in GitHub Actions? Is it needed? If not we can remove it from requirements.txt
Cleanup entrypoint.sh
|
The bedevere actions seem to be working at least on my CPython fork. I still find that the "actions" are slower to execute compared to having it as a Web app/ webhook event. For example, when changing the skip issue/skip news label, the actions need to re-run and takes time before it posts the status. Whereas as a webhook event, it works faster/almost immediate. |
Instead of getting information from webhook payload,
get them from the Actions environment.
Create fixtures for GitHub Actions environment vars.
Adjust tests for main.py.
Remove "ping" handler, not needed in Actions
Still in Draft.
Need help with Dockerising it or make it faster.
Closes #344