-
-
Notifications
You must be signed in to change notification settings - Fork 30.7k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
GH-93521: For dataclasses, filter out
__weakref__
slot if present i…
…n bases (GH-93535) (cherry picked from commit 5849af7) Co-authored-by: Bluenix <bluenixdev@gmail.com>
- Loading branch information
1 parent
f26d1b5
commit 121ab58
Showing
3 changed files
with
61 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 4 additions & 0 deletions
4
Misc/NEWS.d/next/Library/2022-06-06-13-19-43.gh-issue-93521._vE8m9.rst
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
Fixed a case where dataclasses would try to add ``__weakref__`` into the | ||
``__slots__`` for a dataclass that specified ``weakref_slot=True`` when it was | ||
already defined in one of its bases. This resulted in a ``TypeError`` upon the | ||
new class being created. |