fixup! Add NEWS entry

python · May 30, 2022 · 4fa8695 · 4fa8695
1 parent c0a3429
commit 4fa8695
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 19 deletions.
diff --git a/Lib/test/test_ast.py b/Lib/test/test_ast.py
@@ -363,23 +363,12 @@ def test_invalid_position_information(self):
                     compile(tree, '<string>', 'exec')
 
     def test_compilation_of_ast_nodes_with_default_end_position_values(self):
-        tree = ast.Module(
-	        body=[
-                ast.Assign(
-                    targets=[
-                        ast.Name(
-                            id='a',
-                            ctx=ast.Store(),
-                            lineno=10,
-                            col_offset=10)
-                    ],
-                value=ast.Constant(
-                    value=1,
-                    lineno=10,
-                    col_offset=40),
-                lineno=10,
-                col_offset=10)],
-	        type_ignores=[])
+        tree = ast.Module(body=[
+            ast.Import(names=[ast.alias(name='builtins', lineno=1, col_offset=0)], lineno=1, col_offset=0), 
+            ast.Import(names=[ast.alias(name='traceback', lineno=0, col_offset=0)], lineno=0, col_offset=1)
+        ], type_ignores=[])
+
+        # Check that compilation doesn't crash. Note: this may crash explicitly only on debug mode.
         compile(tree, "<string>", "exec")
 
     def test_slice(self):

diff --git a/Misc/NEWS.d/next/Core and Builtins/2022-05-30-18-28-07.bpo-92597.VPs1z1.rst b/Misc/NEWS.d/next/Core and Builtins/2022-05-30-18-28-07.bpo-92597.VPs1z1.rst
diff --git a/Misc/NEWS.d/next/Core and Builtins/2022-05-30-19-00-38.gh-issue-93359.zXV3A0.rst b/Misc/NEWS.d/next/Core and Builtins/2022-05-30-19-00-38.gh-issue-93359.zXV3A0.rst
@@ -0,0 +1,2 @@
+Ensure that custom :mod:`ast` nodes without explicit end positions can be
+compiled. Patch by Pablo Galindo.