fix possible if unlikely leak

python · Dec 20, 2011 · 53aa1d7 · 53aa1d7
1 parent 0f1e3ac
commit 53aa1d7
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/Objects/unicodeobject.c b/Objects/unicodeobject.c
@@ -8888,9 +8888,13 @@ unicode_maketrans(PyUnicodeObject *null, PyObject *args)
         /* create entries for translating chars in x to those in y */
         for (i = 0; i < PyUnicode_GET_SIZE(x); i++) {
             key = PyLong_FromLong(PyUnicode_AS_UNICODE(x)[i]);
+            if (!key)
+                goto err;
             value = PyLong_FromLong(PyUnicode_AS_UNICODE(y)[i]);
-            if (!key || !value)
+            if (!value) {
+                Py_DECREF(key);
                 goto err;
+            }
             res = PyDict_SetItem(new, key, value);
             Py_DECREF(key);
             Py_DECREF(value);