Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Carl Meyer <carl@oddbird.net>
  • Loading branch information
kwi-dk and carljm authored Dec 15, 2022
1 parent 983a9ac commit 5b83afe
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion Lib/test/test_tempfile.py
Original file line number Diff line number Diff line change
Expand Up @@ -1660,7 +1660,7 @@ def test_cleanup_with_error_deleting_symlink(self):
d1 = self.do_create()
d2 = self.do_create(recurse=0)

# Symlink d1/my_symlink -> d2, then give d2 a custom mode to see if changes.
# Symlink d1/my_symlink -> d2, then give d2 a custom mode to see if it changes.
os.symlink(d2.name, os.path.join(d1.name, "my_symlink"))
os.chmod(d2.name, 0o567)
expected_mode = os.stat(d2.name).st_mode # can be impacted by umask etc.
Expand Down
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
Fix a bug :class:`tempfile.TemporaryDirectory` cleanup, which now no longer
Fix a bug in :class:`tempfile.TemporaryDirectory` cleanup, which now no longer
dereferences symlinks when working around file system permission errors.

0 comments on commit 5b83afe

Please sign in to comment.