gh-102251: Fix reference leak in _testsinglephase initialization (#10…

…5082) Correctly decref 'initialized' in init_module() Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
python · May 30, 2023 · d14eb34 · d14eb34
1 parent 219f01b
commit d14eb34
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/Modules/_testsinglephase.c b/Modules/_testsinglephase.c
@@ -140,7 +140,9 @@ init_module(PyObject *module, module_state *state)
     if (initialized == NULL) {
         return -1;
     }
-    if (PyModule_AddObjectRef(module, "_module_initialized", initialized) != 0) {
+    int rc = PyModule_AddObjectRef(module, "_module_initialized", initialized);
+    Py_DECREF(initialized);
+    if (rc < 0) {
         return -1;
     }