Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_code.test_invalid_bytecode is a bit cryptic and flaky #100077

Closed
iritkatriel opened this issue Dec 7, 2022 · 0 comments · Fixed by #100078
Closed

test_code.test_invalid_bytecode is a bit cryptic and flaky #100077

iritkatriel opened this issue Dec 7, 2022 · 0 comments · Fixed by #100078
Assignees
@iritkatriel
Labels
tests Tests in the Lib/test dir type-feature A feature request or enhancement

Comments

@iritkatriel
Copy link
Member

iritkatriel commented Dec 7, 2022 •
edited by bedevere-bot
Loading

This test checks what happens when we try to execute a function with invalid bytecode. It hand-crafts the function's code, which is hard to read and maintain as bytecode changes. It also assumes that 238 is an invalid opcode, which it should at least assert.

Linked PRs
@iritkatriel iritkatriel added type-feature A feature request or enhancement tests Tests in the Lib/test dir skip news labels Dec 7, 2022
@iritkatriel iritkatriel self-assigned this Dec 7, 2022
iritkatriel added a commit to iritkatriel/cpython that referenced this issue Dec 7, 2022
@iritkatriel
pythongh-100077: make test_code.test_invalid_bytecode more robust and…
1c3d4fb 
… maintainable
iritkatriel added a commit to iritkatriel/cpython that referenced this issue Dec 7, 2022
@iritkatriel
pythongh-100077: make test_code.test_invalid_bytecode more robust and…
07310c6 
… maintainable
@iritkatriel iritkatriel mentioned this issue Dec 7, 2022
Merged
iritkatriel added a commit that referenced this issue Dec 7, 2022
@iritkatriel
gh-100077: make test_code.test_invalid_bytecode more robust and maint…
f3e97c9 
…ainable (#100078)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iritkatriel iritkatriel

Labels
tests Tests in the Lib/test dir type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

gh-100077: make test_code.test_invalid_bytecode more robust and maintainable iritkatriel/cpython
1 participant
@iritkatriel