Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Grammatical error in message string for FatalError when calling PyImport_AppendInittab() after Py_Initialize() #101670

Closed
brettcannon opened this issue Feb 8, 2023 · 1 comment
Closed

Grammatical error in message string for FatalError when calling PyImport_AppendInittab() after Py_Initialize() #101670

brettcannon opened this issue Feb 8, 2023 · 1 comment
Labels
easy type-bug An unexpected behavior, bug, or error

Comments

@brettcannon
Copy link
Member

brettcannon commented Feb 8, 2023 •
edited by bedevere-bot
Loading

The following line should have the first instance of "be" replaced with "not":

cpython/Python/import.c

Line 2695 in aacbdb0

Py_FatalError("PyImport_AppendInittab() may be be called after Py_Initialize()");

Linked PRs
@brettcannon brettcannon added type-bug An unexpected behavior, bug, or error easy labels Feb 8, 2023
skirpichev added a commit to skirpichev/cpython that referenced this issue Feb 8, 2023
@skirpichev
pythongh-101670: typo fix in PyImport_AppendInittab()
490ce18
@bedevere-bot bedevere-bot mentioned this issue Feb 8, 2023
Merged
@ericsnowcurrently
Copy link
Member

Nice catch! :)

miss-islington pushed a commit that referenced this issue Feb 8, 2023
@skirpichev
gh-101670: typo fix in PyImport_AppendInittab() (GH-101672)
35dd550
skirpichev added a commit to skirpichev/cpython that referenced this issue Feb 9, 2023
@skirpichev
pythongh-101670: Amend 35dd550
3eeb959
@bedevere-bot bedevere-bot mentioned this issue Feb 9, 2023
Merged
hugovk pushed a commit that referenced this issue Feb 9, 2023
@skirpichev @ericsnowcurrently
gh-101670: typo fix in PyImport_ExtendInittab() (#101723)
cb24118 
Co-authored-by: Eric Snow <ericsnowcurrently@gmail.com>
carljm added a commit to carljm/cpython that referenced this issue Feb 9, 2023
@carljm
Merge branch 'main' into inlinecomp2
be3becc 
* main: (82 commits)
  pythongh-101670: typo fix in PyImport_ExtendInittab() (python#101723)
  pythonGH-99293: Document that `Py_TPFLAGS_VALID_VERSION_TAG` shouldn't be used. (#pythonGH-101736)
  no-issue: Add Dong-hee Na as the cjkcodecs codeowner (pythongh-101731)
  pythongh-101678: Merge math_1_to_whatever() and math_1() (python#101730)
  pythongh-101678: refactor the math module to use special functions from c11 (pythonGH-101679)
  pythongh-85984: Remove legacy Lib/pty.py code. (python#92365)
  pythongh-98831: Use opcode metadata for stack_effect() (python#101704)
  pythongh-101283: Version was just released, so should be changed in 3.11.3 (pythonGH-101719)
  pythongh-101283: Fix use of unbound variable (pythonGH-101712)
  pythongh-101283: Improved fallback logic for subprocess with shell=True on Windows (pythonGH-101286)
  pythongh-101277: Port more itertools static types to heap types (python#101304)
  pythongh-98831: Modernize CALL and family (python#101508)
  pythonGH-101696: invalidate type version tag in `_PyStaticType_Dealloc` (python#101697)
  pythongh-100221: Fix creating dirs in `make sharedinstall` (pythonGH-100329)
  pythongh-101670: typo fix in PyImport_AppendInittab() (pythonGH-101672)
  pythongh-101196: Make isdir/isfile/exists faster on Windows (pythonGH-101324)
  pythongh-101614: Don't treat python3_d.dll as a Python DLL when checking extension modules for incompatibility (pythonGH-101615)
  pythongh-100933: Improve `check_element` helper in `test_xml_etree` (python#100934)
  pythonGH-101578: Normalize the current exception (pythonGH-101607)
  pythongh-47937: Note that Popen attributes are read-only (python#93070)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
easy type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brettcannon @ericsnowcurrently