-
-
Notifications
You must be signed in to change notification settings - Fork 30.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run mypy on Tools/wasm
#109125
Comments
I'm not sure if it's worth keeping a couple of scripts typed, especially based on the restrictions of typing in the repo (e.g., older versions of Python w/o |
We may need to define the scope of what scripts would be worth adding typing, and applying mypy pipeline. |
I'm not sure this needs to be formalised much. I think we should add mypy to CI for self-contained CPython projects where the maintainers of those projects say they'd find it useful. We should avoid doing so for projects where the maintainers of those projects say it wouldn't be useful. |
Once I will be done with refactoring libregrtest #109162 I will need help to add type hints there ;-) IMO it would be a more interesting target than Tools/wasm/ scripts. |
(cherry picked from commit f65497f) Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
Done via #109126, thanks! |
Feature or enhancement
Right now we already have 3 fully typed and checked tools:
mypy
onTools/peg_generator
#108455mypy
oncases_generator
#104504I think we can also add
Tools/wasm
quite easily to this list.Tools/wasm
already has most of the type annotations, but there are some mypy errors to fix.Linked PRs
Tools/wasm
#109126Tools/wasm
(GH-109126) #109561The text was updated successfully, but these errors were encountered: