-
-
Notifications
You must be signed in to change notification settings - Fork 30.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
asyncio.wait_for() doesn't raise builtin TimeoutError #110703
Comments
Hello!
(from https://docs.python.org/3.10/library/asyncio-task.html#asyncio.wait_for) So, seems that you reading docs for new versions, but in fact using a old one :) |
Ah, you're right. I assumed nothing has changed because I expected a note, something like:
Usually that kind of note follow any backwards-incompatible change. Maybe it would be good idea to add that, it could save future readers from the same confusion I had. Anyways, thanks for the quick reply :) |
Pending a clear decision otherwise, I think the suggested line immediately above should be added. |
Feel free to send a PR! |
I've created the PR. Thank you for the opportunity to contribute to CPython :) |
* Remove redundant versionchanged * Add missing versionchanged * Update Doc/library/asyncio-task.rst Co-authored-by: Kumar Aditya <kumaraditya@python.org> --------- Co-authored-by: Kumar Aditya <kumaraditya@python.org>
…GH-110818) * Remove redundant versionchanged * Add missing versionchanged * Update Doc/library/asyncio-task.rst Co-authored-by: Kumar Aditya <kumaraditya@python.org> --------- (cherry picked from commit f81e36f) Co-authored-by: paskozdilar <53006174+paskozdilar@users.noreply.github.com> Co-authored-by: Kumar Aditya <kumaraditya@python.org>
…GH-110818) * Remove redundant versionchanged * Add missing versionchanged * Update Doc/library/asyncio-task.rst Co-authored-by: Kumar Aditya <kumaraditya@python.org> --------- (cherry picked from commit f81e36f) Co-authored-by: paskozdilar <53006174+paskozdilar@users.noreply.github.com> Co-authored-by: Kumar Aditya <kumaraditya@python.org>
…0818) (#110826) gh-110703: Add asyncio.wait_for() change notes for 3.11 (GH-110818) * Remove redundant versionchanged * Add missing versionchanged * Update Doc/library/asyncio-task.rst --------- (cherry picked from commit f81e36f) Co-authored-by: paskozdilar <53006174+paskozdilar@users.noreply.github.com> Co-authored-by: Kumar Aditya <kumaraditya@python.org>
…0818) (#110827) gh-110703: Add asyncio.wait_for() change notes for 3.11 (GH-110818) * Remove redundant versionchanged * Add missing versionchanged * Update Doc/library/asyncio-task.rst --------- (cherry picked from commit f81e36f) Co-authored-by: paskozdilar <53006174+paskozdilar@users.noreply.github.com> Co-authored-by: Kumar Aditya <kumaraditya@python.org>
…GH-110818) * Remove redundant versionchanged * Add missing versionchanged * Update Doc/library/asyncio-task.rst Co-authored-by: Kumar Aditya <kumaraditya@python.org> --------- Co-authored-by: Kumar Aditya <kumaraditya@python.org>
…GH-110818) * Remove redundant versionchanged * Add missing versionchanged * Update Doc/library/asyncio-task.rst Co-authored-by: Kumar Aditya <kumaraditya@python.org> --------- Co-authored-by: Kumar Aditya <kumaraditya@python.org>
Documentation
The documentation page about asyncio.wait_for() function says that:
The TimeoutError hyperlink leads to the built-in exception "TimeoutError", which would lead any sane user to think that asyncio.wait_for() raises builtin TimeoutError.
However, it doesn't:
The above program prints:
Documentation should be changed to reflect what really happens in Python.
Linked PRs
The text was updated successfully, but these errors were encountered: