Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emscripten node support: Clean up old node <= 16 flags #124928

Closed
hoodmane opened this issue Oct 3, 2024 · 1 comment
Closed

Emscripten node support: Clean up old node <= 16 flags #124928

hoodmane opened this issue Oct 3, 2024 · 1 comment
Assignees
@freakboy3742
Labels
build The build process and cross-build OS-emscripten

Comments

@hoodmane
Copy link
Contributor

hoodmane commented Oct 3, 2024 •
edited by bedevere-app bot
Loading

configure.ac has a bunch of HOSTRUNNER configuration that tries to work out what --experimental flags to pass to the node runtime. Most of these are only needed for node <= 16. Node 16 has been end of life since October of 2023. We should remove these.

Linked PRs
@bedevere-app bedevere-app bot mentioned this issue Oct 3, 2024
Merged
@picnixz picnixz added the build The build process and cross-build label Oct 3, 2024
freakboy3742 pushed a commit that referenced this issue Oct 29, 2024
@hoodmane
gh-124928: Emscripten node support: Clean up old node <= 16 flags (#1…
dc2552d 
…24929)

Clean up configure flags for old node versions

These flags are only needed for node <= 16. Node 16 has been end of life since
October of 2023.
@hoodmane
Copy link
Contributor Author

Resolved by #124929.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@freakboy3742 freakboy3742

Labels
build The build process and cross-build OS-emscripten
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@freakboy3742 @brettcannon @hoodmane @picnixz @AlexWaygood