Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change PyMutex_LockFast to take mutex as argument #128033

Closed
kumaraditya303 opened this issue Dec 17, 2024 · 1 comment
Closed

Change PyMutex_LockFast to take mutex as argument #128033

kumaraditya303 opened this issue Dec 17, 2024 · 1 comment
Assignees
@kumaraditya303
Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs) topic-free-threading type-feature A feature request or enhancement

Comments

@kumaraditya303
Copy link
Contributor

kumaraditya303 commented Dec 17, 2024 •
edited by bedevere-app bot
Loading

PyMutex_LockFast is the only function which takes the bits from mutex directly rather than the mutex. It breaks a good abstraction so I propose to change it to take the mutex as its argument like all other functions.

cc @colesbury

Linked PRs
@colesbury
Copy link
Contributor

That makes sense to me.

@picnixz picnixz added interpreter-core (Objects, Python, Grammar, and Parser dirs) type-feature A feature request or enhancement labels Dec 17, 2024
@bedevere-app bedevere-app bot mentioned this issue Dec 18, 2024
Merged
@kumaraditya303 kumaraditya303 self-assigned this Dec 18, 2024
kumaraditya303 added a commit that referenced this issue Dec 18, 2024
@kumaraditya303
gh-128033: change PyMutex_LockFast to take PyMutex as argument (#…
91c5508 
…128054)

Change `PyMutex_LockFast` to take `PyMutex` as argument.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kumaraditya303 kumaraditya303

Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs) topic-free-threading type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@colesbury @picnixz @kumaraditya303