missing termios constants

[conorh]

BPO	7695
Nosy	@vstinner, @tiran
Files	patch_termios_consts_issue7695.diff

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = None
created_at = <Date 2010-01-13.20:02:29.631>
labels = ['type-feature', 'library']
title = 'missing termios constants'
updated_at = <Date 2014-12-31.16:20:36.861>
user = 'https://bugs.python.org/conorh'

bugs.python.org fields:

activity = <Date 2014-12-31.16:20:36.861>
actor = 'akuchling'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Library (Lib)']
creation = <Date 2010-01-13.20:02:29.631>
creator = 'conorh'
dependencies = []
files = ['20015']
hgrepos = []
issue_num = 7695
keywords = ['patch']
message_count = 5.0
messages = ['97736', '97749', '123803', '174714', '174727']
nosy_count = 4.0
nosy_names = ['vstinner', 'christian.heimes', 'conorh', 'Rodolpho.Eckhardt']
pr_nums = []
priority = 'normal'
resolution = None
stage = 'patch review'
status = 'open'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue7695'
versions = ['Python 3.4']

Linked PRs

• gh-51944: Add missing macOS constants to termios #112823
• gh-51944: fix type and missing addition in gh-112823 #112996

[conorh]

Module termios is missing some constants useful for handling control characters under Mac OS X (and Solaris, and probably BSD but I don't have a pure BSD system to test against).

In particular, these systems support a control character "DSUSP" (which is similar to SUSP), but there is no provided symbol for the index into the cc array to use. The correct value for the proposed termios.VDSUSP would be 11 on MacOS and Solaris. I'm no Linux wizard but I don't believe it has this control character.

In addition, MacOS supports a control character STATUS, and the correct value for the proposed termios.VSTATUS would be 18.

Likewise, _POSIX_VDISABLE (or some similar identifier) is missing from the module. I believe the correct value on Solaris would be '\x00', MacOS '\xff', Linux '\x00'.

[conorh]

As these aren't POSIX, changing to feature request.

[RodolphoEckhardt]

Because these constants might not exist on all platforms, the patch uses ifdef's around them.

[akuchling]

Patch seems clearly correct; compiles & works on MacOS. We could just apply this.

[tiran]

The patch looks good to me but it's missing doc updates.

[ronaldoussoren]

#112823 adds all missing public symbols, but does not add _POSIX_VDISABLE because that's a private name.