-
-
Notifications
You must be signed in to change notification settings - Fork 30.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Argument Clinic: support diverting output to buffer, external file, etc #64486
Comments
The long-awaited, highly desirable "buffer" patch is here! With features I figured would never see the light of day. Changes in this patch:
Patch is not ready for checkin, as it still needs documentation. But it's ready for code review! There's a lot of churn in the C files. That's due to the following
|
Can Argument Clinic be simplified when drop support for all alternative outputs besides a side file?
Why this is needed? If buildin function has "args" or "kwargs" keyword arguments, C variables can be renamed to args_value and kwargs_value, as for any reserved keywords (e.g. "default", "int"). Other changes look very good, but these are just add code churn. |
If I removed support for all destinations except files, I might Also, the "file" approach often requires rearranging the file The change of "args" to "_args" is me planning ahead a little; However, I've been thinking about it all morning, and maybe (By the way, my next major patch, enabling signatures to work |
I have backed out the "args" -> "_args" change. Not because I'm giving up on it, or that I necessarily think it's a bad idea, but because there The resulting patch is smaller than the first iteration. And since you said it was fine except for that, I assume this patch is fine and can go in? |
The patch is too large and I don't very conversant with this code, so I just left several minor comments on Rietveld. At first glance all looks good. All works with my patches, results are good. But I see that side fail names have extension .clinic.c. The .c.clinic extension would be better. For now clinic_test is failed: Error: |
I have a fix already in place for the clinic_test.py problem. I disagree with your proposed "foo.c.clinic" nomenclature, and there are advantages to "foo.clinic.c": double-clicking on them will launch the correct editor, and editors will automatically color them correctly. We've had this discussion before, and you weren't able to change my mind then, so please give the bikeshedding a rest. |
New changeset 7f6712954d5d by Larry Hastings in branch 'default': |
Done! |
delaying its output or even redirecting it to a separate file. GitHub-Issue-Link: python/cpython#64486
delaying its output or even redirecting it to a separate file. GitHub-Issue-Link: python/cpython#64486
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
bugs.python.org fields:
The text was updated successfully, but these errors were encountered: