Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ast.increment_lineno does not increment line numbers in the Module.type_ignores list #99341

Closed
ricilake opened this issue Nov 10, 2022 · 1 comment
Labels
type-bug An unexpected behavior, bug, or error

Comments

@ricilake
Copy link

ricilake commented Nov 10, 2022

Bug report

As indicated in the title, ast.increment_lineno() does not seem to increment the lineno attributes in the Module's list of TypeIgnore objects, with the result that the type ignore list is disconnected from the location attributes in the rest of the AST.

Example:

>>> import sys
>>> print(sys.version)
3.11.0 (main, Oct 24 2022, 19:56:01) [GCC 7.5.0]
>>> import ast
>>> example="""def t():\n  a = 3 # type: ignore"""
>>> tree = ast.parse(example, type_comments=True)
>>> ast.increment_lineno(tree, 10)
<ast.Module object at 0x7fa7505fbe50>
>>> print(tree.body[0].lineno)
11
>>> print(tree.body[0].body[0].lineno)
12
>>> print(tree.type_ignores[0].lineno)
2

Your environment

Tested using Python 3.11 on an Ubuntu Linux system.

@ricilake ricilake added the type-bug An unexpected behavior, bug, or error label Nov 10, 2022
isidentical added a commit to isidentical/cpython that referenced this issue Nov 12, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Nov 22, 2022
pythonGH-99422)

(cherry picked from commit 1acdfec)

Co-authored-by: Batuhan Taskaya <isidentical@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Nov 22, 2022
pythonGH-99422)

(cherry picked from commit 1acdfec)

Co-authored-by: Batuhan Taskaya <isidentical@gmail.com>
miss-islington added a commit that referenced this issue Nov 22, 2022
…99422)

(cherry picked from commit 1acdfec)

Co-authored-by: Batuhan Taskaya <isidentical@gmail.com>
miss-islington added a commit that referenced this issue Nov 22, 2022
…99422)

(cherry picked from commit 1acdfec)

Co-authored-by: Batuhan Taskaya <isidentical@gmail.com>
@hauntsaninja
Copy link
Contributor

Thanks for reporting, looks like this has been fixed and backported

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-bug An unexpected behavior, bug, or error
Projects
None yet
Development

No branches or pull requests

2 participants