Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-98680: Add PyBUF_* constants to the Limited API listing #100018

Merged
merged 2 commits into from
Dec 5, 2022

Conversation

encukou
Copy link
Member

@encukou encukou commented Dec 5, 2022

PyBUF_* constants are marked as part of Limited API of Python 3.11+.
These were available in 3.11.0 with Py_LIMITED_API defined for 3.11, and are necessary to use the buffer API. Omitting them in stable_abi.toml was a mistake.

(cc @vstinner)

These were available in 3.11.0 with Py_LIMITED_API defined for 3.11,
and are necessary to use the API.

They should be considered part of the 3.11 Limited API.
@vstinner
Copy link
Member

vstinner commented Dec 5, 2022

Limiled

Typo :-)

@encukou encukou changed the title gh-98680: Add PyBUF_* constants to the Limiled API listing gh-98680: Add PyBUF_* constants to the Limited API listing Dec 5, 2022
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@encukou encukou merged commit f247387 into python:main Dec 5, 2022
@miss-islington
Copy link
Contributor

Thanks @encukou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@encukou encukou deleted the pybuf-flags branch December 5, 2022 17:02
@bedevere-bot
Copy link

GH-100020 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Dec 5, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 5, 2022
…honGH-100018)

``PyBUF_*`` constants are marked as part of Limited API of Python 3.11+.
These were available in 3.11.0 with `Py_LIMITED_API` defined for 3.11,
and are necessary to use the buffer API. Omitting them in `stable_abi.toml`
was a mistake.
(cherry picked from commit f247387)

Co-authored-by: Petr Viktorin <encukou@gmail.com>
miss-islington added a commit that referenced this pull request Dec 5, 2022
``PyBUF_*`` constants are marked as part of Limited API of Python 3.11+.
These were available in 3.11.0 with `Py_LIMITED_API` defined for 3.11,
and are necessary to use the buffer API. Omitting them in `stable_abi.toml`
was a mistake.
(cherry picked from commit f247387)

Co-authored-by: Petr Viktorin <encukou@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants