Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.11] GH-99729: Unlink frames before clearing them #100047

Merged
merged 4 commits into from
Dec 6, 2022

Conversation

brandtbucher
Copy link
Member

@brandtbucher brandtbucher commented Dec 6, 2022

This is a manual backport of the not-yet-merged #100030.

That one should happen first, but I thought I'd get this ready while the buildbots ran.

@brandtbucher brandtbucher added interpreter-core (Objects, Python, Grammar, and Parser dirs) type-crash A hard crash of the interpreter, possibly with a core dump labels Dec 6, 2022
@brandtbucher brandtbucher self-assigned this Dec 6, 2022
@markshannon
Copy link
Member

Looks good.

@markshannon markshannon added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Dec 6, 2022
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @markshannon for commit 5314243 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Dec 6, 2022
@vstinner
Copy link
Member

vstinner commented Dec 6, 2022

I'm curious about "Refleaks" buildbot timings ("Total duration"):

  • AMD64 Fedora Stable Refleaks PR: 46 min 9 sec
  • AMD64 RHEL7 Refleaks PR: 39 min
  • PPC64LE Fedora Stable Refleaks PR: 36 min 12 sec
  • PPC64LE RHEL8 Refleaks PR: 40 min 31 sec
  • aarch64 Fedora Stable Refleaks PR: 40 min 42 sec
  • aarch64 RHEL8 Refleaks PR: 50 min 24 sec
  • s390x Fedora Refleaks PR: 40 min 20 sec
  • s390x RHEL7 Refleaks PR: 56 min 46 sec
  • s390x RHEL8 Refleaks PR: 36 min 57 sec

On-going: PPC64LE RHEL7 Refleaks PR (26 min).

@brandtbucher
Copy link
Member Author

I'm away from my computer for the next hour or so, so feel free to merge when ready.

@pablogsal
Copy link
Member

I'm curious about "Refleaks" buildbot timings ("Total duration"):

  • AMD64 Fedora Stable Refleaks PR: 46 min 9 sec
  • AMD64 RHEL7 Refleaks PR: 39 min
  • PPC64LE Fedora Stable Refleaks PR: 36 min 12 sec
  • PPC64LE RHEL8 Refleaks PR: 40 min 31 sec
  • aarch64 Fedora Stable Refleaks PR: 40 min 42 sec
  • aarch64 RHEL8 Refleaks PR: 50 min 24 sec
  • s390x Fedora Refleaks PR: 40 min 20 sec
  • s390x RHEL7 Refleaks PR: 56 min 46 sec
  • s390x RHEL8 Refleaks PR: 36 min 57 sec

On-going: PPC64LE RHEL7 Refleaks PR (26 min).

What's curious about this?

@pablogsal pablogsal merged commit 2182a71 into python:3.11 Dec 6, 2022
@vstinner
Copy link
Member

vstinner commented Dec 6, 2022

What's curious about this?

On Discord, @markshannon wrote that " PPC64LE RHEL7 Refleaks PR" took "forever" :-)

@markshannon
Copy link
Member

The problem is not that the individual runs take a long time, but that one overworked machine is running many of them, so collectively they take "forever" (actually a few hours)
https://buildbot.python.org/all/#/workers/6

@vstinner
Copy link
Member

vstinner commented Dec 7, 2022

https://buildbot.python.org/all/#/workers/6

I looked at the latest 10 builds. They waited between 1 second and 30 minutes, and the slowest took 1 hour (Refleaks build, tests took 50 min).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs) type-crash A hard crash of the interpreter, possibly with a core dump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants