Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_ast uses infinite_recursion() to prevent crash #100104

Merged
merged 1 commit into from
Dec 8, 2022
Merged

test_ast uses infinite_recursion() to prevent crash #100104

merged 1 commit into from
Dec 8, 2022

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Dec 8, 2022

test.test_ast_recursion_limit() now uses infinite_recursion() of test.support to prevent crashes on debug builds.

Before this change, the test crashed on ARM64 Windows 3.x buildbot worker which builds Python in debug mode.

test.test_ast_recursion_limit() now uses infinite_recursion() of
test.support to prevent crashes on debug builds.

Before this change, the test crashed on ARM64 Windows 3.x buildbot
worker which builds Python in debug mode.
@netlify
Copy link

netlify bot commented Dec 8, 2022

Deploy Preview for python-cpython-preview canceled.

Name Link
🔨 Latest commit 2cf754d
🔍 Latest deploy log https://app.netlify.com/sites/python-cpython-preview/deploys/6391993cdfd72c00089b0f1a

@vstinner vstinner added the needs backport to 3.11 only security fixes label Dec 8, 2022
@vstinner vstinner merged commit cd67c1b into python:main Dec 8, 2022
@miss-islington
Copy link
Contributor

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@vstinner vstinner deleted the test_ast_recursive branch December 8, 2022 08:26
@bedevere-bot
Copy link

GH-100105 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Dec 8, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 8, 2022
test.test_ast_recursion_limit() now uses infinite_recursion() of
test.support to prevent crashes on debug builds.

Before this change, the test crashed on ARM64 Windows 3.x buildbot
worker which builds Python in debug mode.
(cherry picked from commit cd67c1b)

Co-authored-by: Victor Stinner <vstinner@python.org>
miss-islington added a commit that referenced this pull request Dec 8, 2022
test.test_ast_recursion_limit() now uses infinite_recursion() of
test.support to prevent crashes on debug builds.

Before this change, the test crashed on ARM64 Windows 3.x buildbot
worker which builds Python in debug mode.
(cherry picked from commit cd67c1b)

Co-authored-by: Victor Stinner <vstinner@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip issue skip news tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants