Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clarify the 4300-digit limit on int-str conversion #100175

Merged
merged 1 commit into from
Dec 12, 2022

Conversation

nedbat
Copy link
Member

@nedbat nedbat commented Dec 11, 2022

The message now seems to imply that numbers larger than 4300 cannot be stringified. Adding one word clarifies the meaning of the number.

@netlify
Copy link

netlify bot commented Dec 11, 2022

Deploy Preview for python-cpython-preview ready!

Name Link
🔨 Latest commit 577c6af
🔍 Latest deploy log https://app.netlify.com/sites/python-cpython-preview/deploys/6396438aa4824d00089c6e22
😎 Deploy Preview https://deploy-preview-100175--python-cpython-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this makes it clearer.

(I also ran into this error during part 2 of today's Advent of Code, featuring ridiculously large numbers.)

@gpshead
Copy link
Member

gpshead commented Dec 12, 2022

I'm thankful for advent of code giving people a reason to even realize our new limit exists. 😁

@gpshead gpshead added the needs backport to 3.11 only security fixes label Dec 12, 2022
@hugovk hugovk merged commit 935ef59 into python:main Dec 12, 2022
@miss-islington
Copy link
Contributor

Thanks @nedbat for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-100193 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Dec 12, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 12, 2022
(cherry picked from commit 935ef59)

Co-authored-by: Ned Batchelder <ned@nedbatchelder.com>
miss-islington added a commit that referenced this pull request Dec 12, 2022
(cherry picked from commit 935ef59)

Co-authored-by: Ned Batchelder <ned@nedbatchelder.com>
carljm added a commit to carljm/cpython that referenced this pull request Dec 14, 2022
* main: (103 commits)
  pythongh-100248: Add missing `ssl_shutdown_timeout` parameter in `asyncio` docs (python#100249)
  Assorted minor fixes for specialization stats. (pythonGH-100219)
  pythongh-100176: venv: Remove redundant compat code for Python <= 3.2 (python#100177)
  pythonGH-100222: Redefine _Py_CODEUNIT as a union to clarify structure of code unit. (pythonGH-100223)
  pythongh-99955: undef ERROR and SUCCESS before redefining (fixes sanitizer warning) (python#100215)
  pythonGH-100206: use versionadded for the addition of sysconfig.get_default_scheme (python#100207)
  pythongh-81057: Move _Py_RefTotal to the "Ignored Globals" List (pythongh-100203)
  pythongh-81057: Move Signal-Related Globals to _PyRuntimeState (pythongh-100085)
  pythongh-81057: Move faulthandler Globals to _PyRuntimeState (pythongh-100152)
  pythongh-81057: Move tracemalloc Globals to _PyRuntimeState (pythongh-100151)
  pythonGH-100143: Improve collecting pystats for parts of runs (pythonGH-100144)
  pythongh-99955: standardize return values of functions in compiler's code-gen (python#100010)
  pythongh-79218: Define `MS_WIN64` macro for Mingw-w64 64bit on Windows (pythonGH-100137)
  Fix: typo (Indention) (pythonGH-99904)
  pythongh-96715 Remove redundant NULL check in `profile_trampoline` function (python#96716)
  pythongh-100176: remove incorrect version compatibility check from argument clinic (python#100190)
  clarify the 4300-digit limit on int-str conversion (python#100175)
  pythongh-70393: Clarify mention of "middle" scope (python#98839)
  pythongh-99688: Fix outdated tests in test_unary (python#99712)
  pythongh-100174: [Enum] Correct PowersOfThree example. (pythonGH-100178)
  ...
@nedbat nedbat deleted the nedbat/4300-digits branch March 19, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants