-
-
Notifications
You must be signed in to change notification settings - Fork 30.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-35036: Use empty message as default for logger #10024
Conversation
cc @pablogsal for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the catch and the PR!
I have pushed to your branch removing the logline, as it is not doing anything and can be safely deleted. |
Sure, thanks for merging it :) |
Thanks @tirkarthi for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 2.7. |
GH-16637 is a backport of this pull request to the 2.7 branch. |
…10024) Previous to commit ee171a2 the logline was working because of self.info() (now deprecated) defaults to an empty message.
This fixes the change introduced in ee171a2 where
self.info()
was replaced withself.logger.info()
.self.info
was deprecated but it had a default ofmessage=''
and the new change also follows the same. I think this is a no-op and can be removed but that is subjected to approval from the reviewer.Original
self.info
definition :https://bugs.python.org/issue35036