GH-100719: Remove redundant gi_code field from generator object.
#100749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
markshannon
commented
Jan 4, 2023
•
markshannon
commented
- Issue: Code objects, function objects and generator object contain quite a lot of redundant information #100719
| @@ -1962,44 +1962,6 @@ initialize_locals(PyThreadState *tstate, PyFunctionObject *func, | |||
| return -1; | |||
| } | |||
|
|
|||
| /* Consumes references to func, locals and all the args */ | |||
There was a problem hiding this comment.
Why was this moved downwards?
There was a problem hiding this comment.
There was a small change, it now calls clear_thread_frame() rather than _PyEvalFrameClearAndPop(), so now needs to come after clear_thread_frame
ericsnowcurrently
approved these changes
Jan 4, 2023
|
I've converted this to a draft because I want to make the following changes first.
|
|
I'm removing the |
scoder
added a commit
to cython/cython
that referenced
this pull request
Mar 31, 2023
…3.12a6 and replaced with a C-API function. See python/cpython#100749
scoder
added a commit
to cython/cython
that referenced
this pull request
Apr 2, 2023
…3.12a6 and replaced with a C-API function. See python/cpython#100749
JelleZijlstra
pushed a commit
to JelleZijlstra/cpython
that referenced
this pull request
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.