Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-101446: Change repr of collections.OrderedDict #101661

Merged
merged 4 commits into from
Feb 8, 2023

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Feb 7, 2023

Now it is:

>>> from collections import OrderedDict
>>> OrderedDict({1: 'a', 2: 'b'})
OrderedDict({1: 'a', 2: 'b'})

Openning this as a draft to see what tests will fail :)

@sobolevn sobolevn marked this pull request as ready for review February 7, 2023 21:29
@sobolevn sobolevn requested a review from rhettinger as a code owner February 7, 2023 21:29
@rhettinger rhettinger merged commit 790ff6b into python:main Feb 8, 2023
@Gouvernathor
Copy link
Contributor

Out of curiosity, why not using super().repr() instead of recreating a whole new dict ? Wouldn't it save quite some time ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants