Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-100176: Remove outdated Tools/{io,cc,string}bench #101853

Merged
merged 5 commits into from
Feb 17, 2024

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Feb 12, 2023

@arhadthedev
Copy link
Member

BTW, it allows to close gh-32135 as outdated.

@sobolevn
Copy link
Member

@rhettinger had some opinion on this as well.

@erlend-aasland
Copy link
Contributor

Sad to see Håvamål go 😢👁️

1.
Gáttir allar,
áðr gangi fram,
um skoðask skyli,
um skyggnast skyli,
því at óvíst er at vita,
hvar óvinir
sitja á fleti fyrir.
2.
Gefendr heilir!
Gestr er inn kominn,
hvar skal sitja sjá?
Mjök er bráðr,
sá er á bröndum skal
síns of freista frama.
3.
Elds er þörf,
þeims inn er kominn
ok á kné kalinn;
matar ok váða
er manni þörf,
þeim er hefr um fjall farit.
4.
Vatns er þörf,
þeim er til verðar kemr,
þerru ok þjóðlaðar,
góðs of æðis,
ef sér geta mætti,
orðs ok endrþögu.
5.
Vits er þörf,
þeim er víða ratar;
dælt er heima hvat;
at augabragði verðr,
sá er ekki kann
ok með snotrum sitr.
6.
At hyggjandi sinni
skyli-t maðr hræsinn vera,
heldr gætinn at geði;
þá er horskr ok þögull
kemr heimisgarða til,
sjaldan verðr víti vörum,
því at óbrigðra vin
fær maðr aldregi
en mannvit mikit.
7.
Inn vari gestr,
er til verðar kemr,
þunnu hljóði þegir,
eyrum hlýðir,
en augum skoðar;
svá nýsisk fróðra hverr fyrir.
8.
Hinn er sæll,
er sér of getr
lof ok líknstafi;
ódælla er við þat,
er maðr eiga skal
annars brjóstum í.

@hugovk
Copy link
Member Author

hugovk commented Apr 27, 2023

(Resolved conflict)

@hugovk hugovk merged commit aba37d4 into python:main Feb 17, 2024
32 checks passed
@hugovk hugovk deleted the rm-tools-io-cc-stringbench branch February 17, 2024 21:17
@Sophist-UK
Copy link

I would have commented sooner had I known that this was about to happen. It would have been helpful if someone had commented in my PR to ccbench.py that this was being considered so that I would have been notified and might have had a chance to comment before it happened.

I believe it was clear from the extensive discussion about the shortcomings of the current GIL in faster-cpython that the ccbench script is still useful - because it clearly identifies an ongoing performance issue when multithreading with one or more CPU-heavy threads.

That said, I do understand that performance scripts do not really have a place in the cpython source code repo, but unfortunately I do not have the time to rework the updated ccbench script for the pyperformance suite, so I guess it is going to just disappear.

@hugovk
Copy link
Member Author

hugovk commented Feb 18, 2024

I would have commented sooner had I known that this was about to happen. It would have been helpful if someone had commented in my PR to ccbench.py that this was being considered so that I would have been notified and might have had a chance to comment before it happened.

Apologies, I'll ping next time this sort of thing comes up. (btw we wouldn't be allowed to merge your PR because it looks like the CLA isn't signed.)

That said, I do understand that performance scripts do not really have a place in the cpython source code repo, but unfortunately I do not have the time to rework the updated ccbench script for the pyperformance suite, so I guess it is going to just disappear.

Yep, in general, benchmarks are much more useful in pyperformace, because they're run often and people pay attention to their results.

The code hasn't disappeared, it's still in the 3.12 and older branches, and in Git history.

And of course, if there's consensus we can easily revert/re-add bits of this.

@Sophist-UK
Copy link

btw we wouldn't be allowed to merge your PR because it looks like the CLA isn't signed.

Go look at the PR history - I signed the CLA and the relevant label was added. Later the label was removed for some reason unknown to me..

woodruffw pushed a commit to woodruffw-forks/cpython that referenced this pull request Mar 4, 2024
…1853)

Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
…1853)

Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Meta issue: clean up redundant compat code
6 participants