Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-62432: unittest runner: Exit code 5 if no tests were run #102051

Merged
merged 13 commits into from
Apr 27, 2023
Merged

gh-62432: unittest runner: Exit code 5 if no tests were run #102051

merged 13 commits into from
Apr 27, 2023

Commits on Feb 19, 2023

  1. Refactor test_program to allow for multiple test suites

    @stefanor
    stefanor committed Feb 19, 2023
    Configuration menu
    Copy the full SHA
    0a2007d View commit details
    Browse the repository at this point in the history

  2. Refactor test_program to use assertRaises as a context manager

    @stefanor
    stefanor committed Feb 19, 2023
    Configuration menu
    Copy the full SHA
    6532200 View commit details
    Browse the repository at this point in the history

  3. unittest: Print an error message if no tests ran

    @stefanor
    stefanor committed Feb 19, 2023
    Configuration menu
    Copy the full SHA
    ebba337 View commit details
    Browse the repository at this point in the history

  4. unittest runner: Exit code 5 if no tests were run 

    As discussed in https://discuss.python.org/t/unittest-fail-if-zero-tests-were-discovered/21498/7

It is common for test runner misconfiguration to fail to find any tests,
this should be an error.

Fixes: python#62432
    @stefanor
    stefanor committed Feb 19, 2023
    Configuration menu
    Copy the full SHA
    5e1a88d View commit details
    Browse the repository at this point in the history

  5. Count the test run in our stub test so that the suite succeeds

    @stefanor
    stefanor committed Feb 19, 2023
    Configuration menu
    Copy the full SHA
    fb67714 View commit details
    Browse the repository at this point in the history

  6. Update ACKs

    @stefanor
    stefanor committed Feb 19, 2023
    Configuration menu
    Copy the full SHA
    0687ca8 View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2023

  1. Put success first in the if ladder

    @stefanor
    stefanor committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    3ac2e71 View commit details
    Browse the repository at this point in the history

  2. NO TESTS RAN, in past tense

    @stefanor
    stefanor committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    7470779 View commit details
    Browse the repository at this point in the history

  3. The parameter name was testcase

    @stefanor
    stefanor committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    ecb363c View commit details
    Browse the repository at this point in the history

  4. Drop a comma

    @stefanor
    stefanor committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    7d6c322 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into fail-zero-tests

    @hauntsaninja
    hauntsaninja authored Feb 20, 2023
    Configuration menu
    Copy the full SHA
    058e22c View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2023

  1. Merge branch 'main' into fail-zero-tests

    @AlexWaygood
    AlexWaygood authored Apr 26, 2023
    Configuration menu
    Copy the full SHA
    455ca8b View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2023

  1. move 5 to a _NO_TESTS_EXITCODE constant.

    @gpshead
    gpshead authored Apr 27, 2023
    Configuration menu
    Copy the full SHA
    9fbab36 View commit details
    Browse the repository at this point in the history