Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Few coverage nitpicks for the cmath module #102067

Merged
merged 3 commits into from
Feb 22, 2023
Merged

Few coverage nitpicks for the cmath module #102067

merged 3 commits into from
Feb 22, 2023

Commits on Feb 20, 2023

  1. Few coverage nitpicks for the cmath module 

    - partial tests for cosh/sinh overflows (L535 and L771).  I doubt
  both ||-ed conditions could be tested.
- removed inaccessible case in sqrt (L832): ax=ay=0 is handled
  above (L823) because fabs() is exact.  Also added test (checked
  with mpmath and gmpy2) for second condition on that line.
- some trivial tests for isclose (cover all conditions on L1217-1218)
- add comment for uncovered L1018
    @skirpichev
    skirpichev committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    e368127 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into cmath-cov

    @skirpichev
    skirpichev committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    b54488e View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2023

  1. Fix testcase to use correct rounding

    @mdickinson
    mdickinson committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    1387cc2 View commit details
    Browse the repository at this point in the history