-
-
Notifications
You must be signed in to change notification settings - Fork 30.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-102296 Document that inspect.Parameter kinds support ordering #102297
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't look like we currently have any tests asserting that the inspect.Parameter
kinds support ordering. I'm not sure we should document it if it's untested, as that means that it could break in the future without anybody noticing. Would you be interested in adding a test to https://github.com/python/cpython/blob/main/Lib/test/test_inspect.py as part of this PR?
@AlexWaygood I was about to, but actually there is ! cpython/Lib/test/test_inspect.py Lines 3725 to 3726 in e3c3f9f
|
Thanks, not sure how I missed that! |
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM
Status check is done, and it's a success ✅. |
Thanks @Gouvernathor for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11. |
GH-102298 is a backport of this pull request to the 3.11 branch. |
pythonGH-102297) (cherry picked from commit 0db6f44) Co-authored-by: Gouvernathor <44340603+Gouvernathor@users.noreply.github.com> Automerge-Triggered-By: GH:AlexWaygood
GH-102299 is a backport of this pull request to the 3.10 branch. |
pythonGH-102297) (cherry picked from commit 0db6f44) Co-authored-by: Gouvernathor <44340603+Gouvernathor@users.noreply.github.com> Automerge-Triggered-By: GH:AlexWaygood
* main: (67 commits) pythongh-99108: Add missing md5/sha1 defines to Modules/Setup (python#102308) pythongh-100227: Move _str_replace_inf to PyInterpreterState (pythongh-102333) pythongh-100227: Move the dtoa State to PyInterpreterState (pythongh-102331) pythonGH-102305: Expand some macros in generated_cases.c.h (python#102309) Migrate to new PSF mailgun account (python#102284) pythongh-102192: Replace PyErr_Fetch/Restore etc by more efficient alternatives (in Python/) (python#102193) pythonGH-90744: Fix erroneous doc links in the sys module (python#101319) pythongh-87092: Make jump target label equal to the offset of the target in the instructions sequence (python#102093) pythongh-101101: Unstable C API tier (PEP 689) (pythonGH-101102) IDLE: Simplify DynOptionsMenu __init__code (python#101371) pythongh-101561: Add typing.override decorator (python#101564) pythongh-101825: Clarify that as_integer_ratio() output is always normalized (python#101843) pythongh-101773: Optimize creation of Fractions in private methods (python#101780) pythongh-102251: Updates to test_imp Toward Fixing Some Refleaks (pythongh-102254) pythongh-102296 Document that inspect.Parameter kinds support ordering (pythonGH-102297) pythongh-102250: Fix double-decref in COMPARE_AND_BRANCH error case (pythonGH-102287) pythongh-101100: Fix sphinx warnings in `types` module (python#102274) pythongh-91038: Change default argument value to `False` instead of `0` (python#31621) pythongh-101765: unicodeobject: use Py_XDECREF correctly (python#102283) [doc] Improve grammar/fix missing word (pythonGH-102060) ...
Automerge-Triggered-By: GH:AlexWaygood