Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-100227: Move next_keys_version to PyInterpreterState #102335

Merged
merged 2 commits into from
Mar 9, 2023
Merged

gh-100227: Move next_keys_version to PyInterpreterState #102335

merged 2 commits into from
Mar 9, 2023

Conversation

ericsnowcurrently
Copy link
Member

@ericsnowcurrently ericsnowcurrently commented Feb 28, 2023 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot mentioned this pull request Feb 28, 2023
Closed
@ericsnowcurrently ericsnowcurrently merged commit 5e5acd2 into python:main Mar 9, 2023
@ericsnowcurrently ericsnowcurrently deleted the isolate-dict-next-keys-version branch March 9, 2023 01:04
@ericsnowcurrently
Copy link
Member Author

FYI, benchmark results show that this change has no significant impact on performance. It showed 1.01x slower, but a subsequent run showed no change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@methane methane Awaiting requested review from methane methane is a code owner

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ericsnowcurrently @bedevere-bot