Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-103417: use time.monotonic in the example for sched.scheduler #103418

Merged
merged 2 commits into from
Apr 12, 2023
Merged

gh-103417: use time.monotonic in the example for sched.scheduler #103418

merged 2 commits into from
Apr 12, 2023

Conversation

nburns
Copy link
Contributor

@nburns nburns commented Apr 10, 2023 •
edited by bedevere-bot
Loading

updates the docs for scheduler.sched to use a monontonic clock to avoid time bugs
#103417

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir skip news labels Apr 10, 2023
@bedevere-bot bedevere-bot mentioned this pull request Apr 10, 2023
Closed
@cpython-cla-bot
Copy link

cpython-cla-bot bot commented Apr 10, 2023 •
edited
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

sobolevn
sobolevn approved these changes Apr 11, 2023
View reviewed changes
Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable, thank you!

hauntsaninja
hauntsaninja approved these changes Apr 12, 2023
View reviewed changes
Copy link
Contributor

@hauntsaninja hauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hauntsaninja hauntsaninja merged commit f2b7ecb into python:main Apr 12, 2023
@miss-islington
Copy link
Contributor

Thanks @nburns for the PR, and @hauntsaninja for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 12, 2023
@nburns @miss-islington
pythongh-103417: use time.monotonic in the example for sched.scheduler (
b463c64 
pythonGH-103418)

(cherry picked from commit f2b7ecb)

Co-authored-by: Nick Burns <nburns@users.noreply.github.com>
@bedevere-bot
Copy link

GH-103468 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Apr 12, 2023
miss-islington added a commit that referenced this pull request Apr 12, 2023
@miss-islington @nburns
gh-103417: use time.monotonic in the example for sched.scheduler (GH-…
e643412 
…103418)

(cherry picked from commit f2b7ecb)

Co-authored-by: Nick Burns <nburns@users.noreply.github.com>
@nburns nburns deleted the issue-103417 branch April 12, 2023 17:11
aisk pushed a commit to aisk/cpython that referenced this pull request Apr 18, 2023
@nburns @aisk
pythongh-103417: use time.monotonic in the example for sched.scheduler (
e70f99c 
python#103418)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hauntsaninja hauntsaninja hauntsaninja approved these changes

@sobolevn sobolevn sobolevn approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nburns @miss-islington @bedevere-bot @sobolevn @hauntsaninja