GH-103082: Turn on branch events for FOR_ITER instructions. #103507
Conversation
| ('jump', 'func', 6, 2), | ||
| ('branch', 'func', 2, 2), | ||
| ('branch', 'func', 3, 4), | ||
| ('jump', 'func', 4, 2), |
There was a problem hiding this comment.
is this the jump over the else?
There was a problem hiding this comment.
No, this is the jump back to the start of the loop.
| ('line', 'func', 4), | ||
| ('jump', 'func', 4, 2), | ||
| ('branch', 'func', 2, 2), | ||
| ('line', 'func', 2), |
There was a problem hiding this comment.
isn't the line event suppose to come before the branch on that line?
There was a problem hiding this comment.
The line event becomes before any other events for that instruction, but the jumps and branches are for other instructions.
The jump 4 -> 2 is the jump back to the FOR_ITER. The FOR_ITER instruction isn't the first instruction on line 2. The branch 2 -> 2 is the exit from the FOR_ITER.
The final "line 2" event is from the implicit return None which has line number 2.
It is marked as a line event because the previous instruction has a different line number.
TBH, line events aren't that useful for this sort of tracing, their use case is for debuggers.
* main: pythongh-103479: [Enum] require __new__ to be considered a data type (pythonGH-103495) pythongh-103365: [Enum] STRICT boundary corrections (pythonGH-103494) pythonGH-103488: Use return-offset, not yield-offset. (pythonGH-103502) pythongh-103088: Fix test_venv error message to avoid bytes/str warning (pythonGH-103500) pythonGH-103082: Turn on branch events for FOR_ITER instructions. (python#103507) pythongh-102978: Fix mock.patch function signatures for class and staticmethod decorators (python#103228) pythongh-103462: Ensure SelectorSocketTransport.writelines registers a writer when data is still pending (python#103463) pythongh-95299: Rework test_cppext.py to not invoke setup.py directly (python#103316)
Turn on
BRANCHevents forFOR_ITERinstruction, and add test.Skipping news as this will be covered by the main news/what's new and documentation for PEP 669.