-
-
Notifications
You must be signed in to change notification settings - Fork 30.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-103548: Improve performance of pathlib.Path.[is_]absolute()
#103549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pass the *unnormalized* path to `os.path.isabs()`. When making an empty path absolute, avoid calling `os.path.join()`, and prevent pathlib from later re-normalizing the result of `os.getcwd()` by storing it as `path._str`.
AlexWaygood
added
type-feature
A feature request or enhancement
performance
Performance or resource usage
3.12
bugs and security fixes
labels
May 6, 2023
AlexWaygood
reviewed
May 6, 2023
AlexWaygood
reviewed
May 6, 2023
Misc/NEWS.d/next/Library/2023-04-14-21-16-05.gh-issue-103548.lagdpp.rst
Outdated
Show resolved
Hide resolved
AlexWaygood
approved these changes
May 6, 2023
AlexWaygood
approved these changes
May 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
jbower-fb
pushed a commit
to jbower-fb/cpython-jbowerfb
that referenced
this pull request
May 8, 2023
pythonGH-103549) Improve performance of `pathlib.Path.absolute()` and `cwd()` by joining paths only when necessary. Also improve performance of `PurePath.is_absolute()` on Posix by skipping path parsing and normalization.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
3.12
bugs and security fixes
performance
Performance or resource usage
topic-pathlib
type-feature
A feature request or enhancement
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass the unnormalized path to
os.path.isabs()
:When making an empty path absolute, avoid calling
os.path.join()
, and prevent pathlib from later re-normalizing the result ofos.getcwd()
by storing it aspath._str
:pathlib.Path.[is_]absolute()
#103548