GH-65238: Fix stripping of trailing slash in pathlib #103595
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This brings pathlib in line with *IEEE Std 1003.1-2017*, where trailing slashes are meaningful to path resolution and should not be discarded. See https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap04.html#tag_04_13
|
Closing this PR as the change is too invasive to make right now. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings pathlib in line with IEEE Std 1003.1-2017, where trailing slashes are meaningful to path resolution and should not be discarded.
This is the last known bug in pathlib's path normalization. Fixing such bugs is necessary if we're to return an unnormalized path from
Path.__fspath__()as an optimization - see #102783. It is also helpful for solving #79634 and #102613.Although most bugfixes involve changing behaviour, in this case the change is reasonably significant. As such I'd like this to land early in the 3.13 alpha cycle and to skip backporting.