Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-103743: Add PyUnstable_Object_GC_NewWithExtraData #103744

Merged
merged 9 commits into from
May 2, 2023
Merged

gh-103743: Add PyUnstable_Object_GC_NewWithExtraData #103744

merged 9 commits into from
May 2, 2023

Commits on Apr 24, 2023

  1. pythongh-103743: Add PyUnstable_Object_GC_NewWithExtraData (python#10… 

    …3743)
    @jbradaric
    jbradaric committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    d644206 View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2023

  1. Merge branch 'main' into jbradaric/obj-new-with-extra-data

    @ambv
    ambv authored Apr 25, 2023
    Configuration menu
    Copy the full SHA
    14975c0 View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2023

  1. Don't suggest PEP 697 will be a solution

    @encukou
    encukou committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    52135dc View commit details
    Browse the repository at this point in the history

  2. Move declaration to Include/cpython 

    That way it doesn't need the Py_LIMITED_API guard
    @encukou
    encukou committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    e2c4b37 View commit details
    Browse the repository at this point in the history

  3. Style nitpicks

    @encukou
    encukou committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    ea9e9ac View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2023

  1. Clarify the docs a bit

    @encukou
    encukou committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    f9817ca View commit details
    Browse the repository at this point in the history

  2. Convert the test class to a heap type

    @encukou
    encukou committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    f0098d6 View commit details
    Browse the repository at this point in the history

  3. Initialize the memory 

    This is a further workaround: this time for the fact that
we can't rely on tp_alloc, which zeroes the memory (including
memory for subclasses, like slots in the test) for normal classes.

For the test type, this means the instances aren't initialized twice
(once in PyUnstable_Object_GC_NewWithExtraData, once again with
PyObject_Init after zeroing). Initializing twice throws off the global
refcount total in debug builds.
    @encukou
    encukou committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    cfa59d7 View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2023

  1. Doc style fixes 

    Fix indentation and reword some parts to sound more natural.

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
    @jbradaric @erlend-aasland
    jbradaric and erlend-aasland authored Apr 29, 2023
    Configuration menu
    Copy the full SHA
    525705a View commit details
    Browse the repository at this point in the history