Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-100370: fix OverflowError in sqlite3.Connection.blobopen for 32-bit builds #103902

Merged
merged 3 commits into from
May 7, 2023

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Apr 26, 2023

@erlend-aasland
Copy link
Contributor Author

cc. @TheCatPlusPlus, can you check if this works for you? Unfortunately, I don't have a Windows development environment to test this on.

@erlend-aasland erlend-aasland marked this pull request as ready for review April 27, 2023 07:11
@erlend-aasland
Copy link
Contributor Author

I'm landing this tomorrow.

@erlend-aasland
Copy link
Contributor Author

!buildbot .*Windows.Refleaks.

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @erlend-aasland for commit 33e196b 🤖

The command will test the builders whose names match following regular expression: .*Windows.*Refleaks.*

The builders matched are:

@erlend-aasland
Copy link
Contributor Author

!buildbot .*Win.Refleak.

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @erlend-aasland for commit 33e196b 🤖

The command will test the builders whose names match following regular expression: .*Win.*Refleak.*

The builders matched are:

@erlend-aasland erlend-aasland merged commit a05bad3 into python:main May 7, 2023
@erlend-aasland erlend-aasland deleted the sqlite-blobopen-fix branch May 7, 2023 10:55
@bedevere-bot

This comment was marked as off-topic.

@erlend-aasland
Copy link
Contributor Author

Blob support was introduced in 3.11; we need to backport this.

@erlend-aasland erlend-aasland added the needs backport to 3.11 only security fixes label May 8, 2023
@miss-islington
Copy link
Contributor

Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @erlend-aasland, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker a05bad3254e2ae5fdf558dfdb65899a2298d8ded 3.11

@bedevere-bot
Copy link

GH-104285 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label May 8, 2023
erlend-aasland added a commit to erlend-aasland/cpython that referenced this pull request May 8, 2023
erlend-aasland added a commit that referenced this pull request May 8, 2023
jbower-fb pushed a commit to jbower-fb/cpython-jbowerfb that referenced this pull request May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sqlite3.Connection.blobopen() can fail with OverflowError on large rowids
3 participants