Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-101819: Refactor _io futher in preparation for module isolation #104369

Merged
merged 11 commits into from
May 11, 2023
Merged

gh-101819: Refactor _io futher in preparation for module isolation #104369

merged 11 commits into from
May 11, 2023

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented May 10, 2023 •
edited
Loading

In fileio.c:

  • Replace query with parameter in err_mode()
  • Fetch module state by defining class in:
    • _io.FileIO.read
    • _io.FileIO.readinto
    • _io.FileIO.truncate
    • _io.FileIO.write

In textio.c:

  • Replace query with parameter in _unsupported()

In winconsoleio.c:

  • Replace query with parameter in err_mode()
  • Replace query with parameter in readinto()
  • Fetch module state by defining class in:
    • _WindowsConsoleIO.read
    • _WindowsConsoleIO.readinto
    • _WindowsConsoleIO.write

@erlend-aasland
Refactor: replace query with parameter
0bfd278 
Pass module state as parameter to err_mode()
@erlend-aasland
Fetch module state by class in _io.FileIO.readinto
8196135
@erlend-aasland
Fetch module state by class in _io.FileIO.read
9584041
@erlend-aasland
Fetch module state by class in _io.FileIO.write
097f147
@erlend-aasland
Fetch module state by class in _io.FileIO.truncate
c4e0940
@erlend-aasland
Refactor: replace query with parameter
7f34d0a 
Pass module state to _unsupported() in textio.c
@erlend-aasland
Fetch module state by class in _WindowsConsoleIO.close
cc1c8f8
@erlend-aasland
Refactor: replace query with parameter
0b3d502 
Pass module state to err_mode() in winconsoleio.c
@erlend-aasland
Refactor: change function declaration
c07026f 
Pass defining class to:

- _WindowsConsoleIO.read
- _WindowsConsoleIO.readinto
- _WindowsConsoleIO.write
@erlend-aasland
Refactor: replace query with parameter
6fbda70 
Pass module state to readinto() in winconsoleio.c
@erlend-aasland
Fetch module state by class where possible in winconsoleio.c
50399ab
@bedevere-bot bedevere-bot mentioned this pull request May 10, 2023
Closed
@erlend-aasland
Copy link
Contributor Author

(The diff looks scarier than it is, bco. the clinic changes; without generated files, the diff is 3 files changed, 91 insertions(+), 63 deletions(-))

@kumaraditya303 kumaraditya303 merged commit d0a738c into python:main May 11, 2023
@kumaraditya303 kumaraditya303 deleted the isolate-io/refactor-part2 branch May 11, 2023 10:26
vstinner
vstinner reviewed May 11, 2023
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review after merge: LGTM.

carljm added a commit to carljm/cpython that referenced this pull request May 11, 2023
@carljm
Merge branch 'main' into supermon
19b3d9e 
* main: (27 commits)
  pythongh-87849: fix SEND specialization family definition (pythonGH-104268)
  pythongh-101819: Adapt _io.IOBase.seek and _io.IOBase.truncate to Argument Clinic (python#104384)
  pythongh-101819: Adapt _io._Buffered* methods to Argument Clinic (python#104367)
  pythongh-101819: Refactor `_io` futher in preparation for module isolation (python#104369)
  pythongh-101819: Adapt _io.TextIOBase methods to Argument Clinic (python#104383)
  pythongh-101117: Improve accuracy of sqlite3.Cursor.rowcount docs (python#104287)
  pythonGH-92184: Convert os.altsep to '/' in filenames when creating ZipInfo objects (python#92185)
  pythongh-104357: fix inlined comprehensions that close over iteration var (python#104368)
  pythonGH-90208: Suppress OSError exceptions from `pathlib.Path.glob()` (pythonGH-104141)
  pythonGH-102181: Improve specialization stats for SEND (pythonGH-102182)
  pythongh-103000: Optimise `dataclasses.asdict` for the common case (python#104364)
  pythongh-103538: Remove unused TK_AQUA code (pythonGH-103539)
  pythonGH-87695: Fix OSError from `pathlib.Path.glob()` (pythonGH-104292)
  pythongh-104263: Rely on Py_NAN and introduce Py_INFINITY (pythonGH-104202)
  pythongh-104010: Separate and improve docs for `typing.get_origin` and `typing.get_args` (python#104013)
  pythongh-101819: Adapt _io._BufferedIOBase_Type methods to Argument Clinic (python#104355)
  pythongh-103960: Dark mode: invert image brightness (python#103983)
  pythongh-104252: Immortalize Py_EMPTY_KEYS (pythongh-104253)
  pythongh-101819: Clean up _io windows console io after pythongh-104197 (python#104354)
  pythongh-101819: Harden _io init (python#104352)
  ...
carljm added a commit to carljm/cpython that referenced this pull request May 11, 2023
@carljm
Merge branch 'main' into fixloadsuperspec
4456dd6 
* main:
  pythongh-87849: fix SEND specialization family definition (pythonGH-104268)
  pythongh-101819: Adapt _io.IOBase.seek and _io.IOBase.truncate to Argument Clinic (python#104384)
  pythongh-101819: Adapt _io._Buffered* methods to Argument Clinic (python#104367)
  pythongh-101819: Refactor `_io` futher in preparation for module isolation (python#104369)
  pythongh-101819: Adapt _io.TextIOBase methods to Argument Clinic (python#104383)
  pythongh-101117: Improve accuracy of sqlite3.Cursor.rowcount docs (python#104287)
  pythonGH-92184: Convert os.altsep to '/' in filenames when creating ZipInfo objects (python#92185)
  pythongh-104357: fix inlined comprehensions that close over iteration var (python#104368)
  pythonGH-90208: Suppress OSError exceptions from `pathlib.Path.glob()` (pythonGH-104141)
@cjwatson cjwatson mentioned this pull request Aug 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner left review comments

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@erlend-aasland @vstinner @kumaraditya303 @bedevere-bot