gh-101819: Explicitly disallow pickle protocols 0 and 1 in _io #104370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is part of the preparations for isolating the _io module.
|
See #84258 (comment) and #85224 (comment), for more info |
|
I'm not confortable to have to dig deep into the bug tracker to get reliable information about object serialization. Can it be written in the Python documentation instead? Since these comments, I recall that @serhiy-storchaka made generic changes on base object type so it's no longer needed, no?
|
Hm, perhaps we only need to change the _io tests. |
|
I believe you are right, @vstinner; there is no need for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of the preparations for isolating the _io module.
_ioextension module #101819