Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-104050: Run mypy on clinic.py in CI #104421

Merged
merged 16 commits into from
May 15, 2023
Merged

gh-104050: Run mypy on clinic.py in CI #104421

merged 16 commits into from
May 15, 2023
+101 −24

Commits on May 1, 2023

  1. Slightly annotate cpp.py

    @erlend-aasland
    erlend-aasland committed May 1, 2023
    Configuration menu
    Copy the full SHA
    ca8532b View commit details
    Browse the repository at this point in the history

  2. Slightly annotate clinic.py

    @erlend-aasland
    erlend-aasland committed May 1, 2023
    Configuration menu
    Copy the full SHA
    d2ec2ef View commit details
    Browse the repository at this point in the history

  3. Address review 

    - ditch no-return
- use callable from collections.abc
- use namedtuple from typing
    @erlend-aasland
    erlend-aasland committed May 1, 2023
    Configuration menu
    Copy the full SHA
    801af38 View commit details
    Browse the repository at this point in the history

Commits on May 12, 2023

  1. Add basic mypy workflow to CI

    @AlexWaygood
    AlexWaygood committed May 12, 2023
    Configuration menu
    Copy the full SHA
    00183ff View commit details
    Browse the repository at this point in the history

  2. Make the type check pass

    @AlexWaygood
    AlexWaygood committed May 12, 2023
    Configuration menu
    Copy the full SHA
    4bdd409 View commit details
    Browse the repository at this point in the history

  3. Tweak workflow file

    @AlexWaygood
    AlexWaygood committed May 12, 2023
    Configuration menu
    Copy the full SHA
    632843b View commit details
    Browse the repository at this point in the history

  4. improve workflow file

    @AlexWaygood
    AlexWaygood authored May 12, 2023
    Configuration menu
    Copy the full SHA
    f7e7a25 View commit details
    Browse the repository at this point in the history

  5. Add some more return annotations 

    Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
    @AlexWaygood @sobolevn
    AlexWaygood and sobolevn authored May 12, 2023
    Configuration menu
    Copy the full SHA
    510e08b View commit details
    Browse the repository at this point in the history

  6. simpler glob 

    Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
    @AlexWaygood @hugovk
    AlexWaygood and hugovk authored May 12, 2023
    Configuration menu
    Copy the full SHA
    773c2ba View commit details
    Browse the repository at this point in the history

  7. Address various reviews!

    @AlexWaygood
    AlexWaygood committed May 12, 2023
    Configuration menu
    Copy the full SHA
    6c7ecb9 View commit details
    Browse the repository at this point in the history

  8. more from Hugo 

    Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
    @AlexWaygood @hugovk
    AlexWaygood and hugovk authored May 12, 2023
    Configuration menu
    Copy the full SHA
    717ee47 View commit details
    Browse the repository at this point in the history

  9. Fix ini syntax

    @AlexWaygood
    AlexWaygood committed May 12, 2023
    Configuration menu
    Copy the full SHA
    62669d1 View commit details
    Browse the repository at this point in the history

  10. Unused import

    @AlexWaygood
    AlexWaygood authored May 12, 2023
    Configuration menu
    Copy the full SHA
    ddd0843 View commit details
    Browse the repository at this point in the history

  11. Merge branch 'main' into clinic-mypy-check

    @AlexWaygood
    AlexWaygood authored May 12, 2023
    Configuration menu
    Copy the full SHA
    b7158db View commit details
    Browse the repository at this point in the history

Commits on May 13, 2023

  1. Restore compatibility with Python 3.8

    @AlexWaygood
    AlexWaygood committed May 13, 2023
    Configuration menu
    Copy the full SHA
    9fcd87f View commit details
    Browse the repository at this point in the history

Commits on May 15, 2023

  1. Revert "Restore compatibility with Python 3.8" 

    This reverts commit 9fcd87f.
    @AlexWaygood
    AlexWaygood committed May 15, 2023
    Configuration menu
    Copy the full SHA
    010f0dd View commit details
    Browse the repository at this point in the history