Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.11] gh-104372: Cleanup _posixsubprocess make_inheritable for async signal safety gh-104518 #104785

Merged
merged 7 commits into from
May 24, 2023
Merged

[3.11] gh-104372: Cleanup _posixsubprocess make_inheritable for async signal safety gh-104518 #104785

merged 7 commits into from
May 24, 2023

Commits on May 23, 2023

  1. pythongh-104372: Cleanup _posixsubprocess make_inheritable for asyn… 

    …c signal safety and no GIL requirement (python#104518)

Move all of the Python C API calls into the parent process up front
instead of doing PyLong_AsLong and PyErr_Occurred and PyTuple_GET from
the post-fork/vfork child process.

Much of this was long overdue. We shouldn't have been using PyTuple and
PyLong APIs within all of these low level functions anyways.

(cherry picked from commit c649df6)
    @gpshead
    gpshead committed May 23, 2023
    Configuration menu
    Copy the full SHA
    de47455 View commit details
    Browse the repository at this point in the history

  2. [3.11] pythongh-104372: Cleanup _posixsubprocess make_inheritable f… 

    …or async signal safety and no GIL requirement (pythonGH-104518)

Move all of the Python C API calls into the parent process up front
instead of doing PyLong_AsLong and PyErr_Occurred and PyTuple_GET from
the post-fork/vfork child process.

Much of this was long overdue. We shouldn't have been using PyTuple and
PyLong APIs within all of these low level functions anyways..
(cherry picked from commit c649df6)

Co-authored-by: Gregory P. Smith <greg@krypto.org>
    @gpshead
    gpshead committed May 23, 2023
    Configuration menu
    Copy the full SHA
    0991dae View commit details
    Browse the repository at this point in the history

  3. Don't use Raw malloc & free. 

    Backport of d1732fe to 3.11 from python#104697.
    @gpshead
    gpshead committed May 23, 2023
    Configuration menu
    Copy the full SHA
    c684290 View commit details
    Browse the repository at this point in the history

  4. Fix the backport for pre-argument-clinic life.

    @gpshead
    gpshead committed May 23, 2023
    Configuration menu
    Copy the full SHA
    0ecbcba View commit details
    Browse the repository at this point in the history

  5. Merge branch '3.11' into backport-c649df6-3.11

    @gpshead
    gpshead authored May 23, 2023
    Configuration menu
    Copy the full SHA
    b0a7c51 View commit details
    Browse the repository at this point in the history

  6. cleanup to keep the backport more diff concise.

    @gpshead
    gpshead authored May 23, 2023
    Configuration menu
    Copy the full SHA
    c058694 View commit details
    Browse the repository at this point in the history

  7. only check PyErr_Occurred if it returned -1

    @gpshead
    gpshead authored May 23, 2023
    Configuration menu
    Copy the full SHA
    c364eaa View commit details
    Browse the repository at this point in the history