Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-104866: Tokenize should emit NEWLINE after exiting block with comment #104870

Merged
merged 1 commit into from
May 24, 2023
Merged

gh-104866: Tokenize should emit NEWLINE after exiting block with comment #104870

merged 1 commit into from
May 24, 2023

Conversation

lysnikolaou
Copy link
Contributor

@lysnikolaou lysnikolaou commented May 24, 2023 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot mentioned this pull request May 24, 2023
Closed
@pablogsal
Copy link
Member

Good catch!

@pablogsal pablogsal merged commit c90a862 into python:main May 24, 2023
@miss-islington
Copy link
Contributor

Thanks @lysnikolaou for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 24, 2023
@lysnikolaou @miss-islington
pythongh-104866: Tokenize should emit NEWLINE after exiting block wit…
3c3ea89 
…h comment (pythonGH-104870)

(cherry picked from commit c90a862)

Co-authored-by: Lysandros Nikolaou <lisandrosnik@gmail.com>
@bedevere-bot
Copy link

GH-104872 is a backport of this pull request to the 3.12 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.12 bug and security fixes label May 24, 2023
terryjreedy pushed a commit that referenced this pull request May 24, 2023
@miss-islington @lysnikolaou
[3.12] gh-104866: Tokenize should emit NEWLINE after exiting block wi…
ddc29c8 
…th comment (GH-104870) (#104872)

gh-104866: Tokenize should emit NEWLINE after exiting block with comment (GH-104870)
(cherry picked from commit c90a862)

Co-authored-by: Lysandros Nikolaou <lisandrosnik@gmail.com>
@pablogsal pablogsal mentioned this pull request May 25, 2023
Closed
@erlend-aasland erlend-aasland mentioned this pull request Jun 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablogsal pablogsal pablogsal approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lysnikolaou @pablogsal @miss-islington @bedevere-bot