Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-104614: Fix potential ref. leak in _testcapimodule/get_basic_static_type() #105225

Merged
merged 1 commit into from
Jun 2, 2023
Merged

gh-104614: Fix potential ref. leak in _testcapimodule/get_basic_static_type() #105225

merged 1 commit into from
Jun 2, 2023

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Jun 2, 2023 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot mentioned this pull request Jun 2, 2023
Closed
@erlend-aasland erlend-aasland mentioned this pull request Jun 2, 2023
Merged
ericsnowcurrently
ericsnowcurrently approved these changes Jun 2, 2023
View reviewed changes
Copy link
Member

@ericsnowcurrently ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erlend-aasland erlend-aasland merged commit e01b04c into python:main Jun 2, 2023
@miss-islington
Copy link
Contributor

Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 2, 2023
@erlend-aasland @miss-islington
pythongh-104614: Fix potential ref. leak in _testcapimodule/get_basic…
4acf6fa 
…_static_type() (pythonGH-105225)

(cherry picked from commit e01b04c)

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
@erlend-aasland erlend-aasland deleted the fix-test branch June 2, 2023 16:44
@bedevere-bot
Copy link

GH-105248 is a backport of this pull request to the 3.12 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.12 bug and security fixes label Jun 2, 2023
erlend-aasland added a commit that referenced this pull request Jun 2, 2023
@miss-islington @erlend-aasland
[3.12] gh-104614: Fix potential ref. leak in _testcapimodule/get_basi…
72d5dfa 
…c_static_type() (GH-105225) (#105248)

(cherry picked from commit e01b04c)

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
@erlend-aasland erlend-aasland mentioned this pull request Jun 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericsnowcurrently ericsnowcurrently ericsnowcurrently approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@erlend-aasland @miss-islington @bedevere-bot @ericsnowcurrently