Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.11] gh-105286: Further improvements to typing.py docstrings (GH-105363) #105417

Merged
merged 6 commits into from
Jun 7, 2023

Conversation

JelleZijlstra
Copy link
Member

@JelleZijlstra JelleZijlstra commented Jun 7, 2023

(cherry picked from commit 9a89f1b)

pythonGH-105363).

(cherry picked from commit 9a89f1b)

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Lib/typing.py Outdated Show resolved Hide resolved
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@AlexWaygood AlexWaygood enabled auto-merge (squash) June 7, 2023 13:11
@AlexWaygood AlexWaygood self-assigned this Jun 7, 2023
@AlexWaygood
Copy link
Member

I have no idea why the "Check if generated files are up to date" check is failing (I was hoping merging in main would fix it) ☹️

I won't be able to merge past it, since it's a "required" CI check.

@JelleZijlstra
Copy link
Member Author

JelleZijlstra commented Jun 7, 2023

Weirdly the check doesn't fail on other 3.11 PRs. I guess I'll try merging 3.11 in again.

@AlexWaygood
Copy link
Member

AlexWaygood commented Jun 7, 2023

Weirdly the check doesn't fail on other 3.11 PRs

It seems to be failing on all PRs that touch .py files, but not on PRs that only touch .rst files. Presumably because different CI checks run on PRs that are deemed to be docs-only PRs

@JelleZijlstra
Copy link
Member Author

Opening an issue in a moment

@AlexWaygood AlexWaygood merged commit 3a195f3 into python:3.11 Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants