-
-
Notifications
You must be signed in to change notification settings - Fork 30.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-100227: Lock Around Adding Global Audit Hooks #105515
gh-100227: Lock Around Adding Global Audit Hooks #105515
Conversation
I'd be just as happy with documenting that you need to self-synchronize when using this function. It should only be being called by embedders anyway. But this change looks okay. I'm not as familiar with our usual locking pattern though, so I'm trusting you're following that. |
FWIW, we didn't have one before per-interpreter GIL. I've tried to be consistent, though, as I've been inventing the pattern. 😄 |
Thanks @ericsnowcurrently for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12. |
Sorry, @ericsnowcurrently, I could not cleanly backport this to |
Thanks @ericsnowcurrently for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12. |
Sorry @ericsnowcurrently, I had trouble checking out the |
Thanks @ericsnowcurrently for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12. |
Sorry @ericsnowcurrently, I had trouble checking out the |
Thanks @ericsnowcurrently for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12. |
Sorry @ericsnowcurrently, I had trouble checking out the |
The risk of a race with this state is relatively low, but we play it safe anyway.
GH-105525 is a backport of this pull request to the 3.12 branch. |
The risk of a race with this state is relatively low, but we play it safe anyway.